Adriaan de Jong wrote: > > > About the whitespace: it's a tad difficult to split the patches > > > now. Are you sure it wouldn't be acceptable this way?
I may have misunderstood this. (I read "now" as "this late", but I guess maybe you meant "this early".) > > I'd suggest that we primarily do code review now. .. > > I'd expect Adriaan to also implement our review comments as well. .. > That's exactly what I was hoping for. I've tried to stay within any > coding standards that I could find within the code. I'm making a > note of any comments people have, and will include them in the > actual 2.2 git rebase. As soon as that's done I can start making > use of the other git commands. I'd use git for the patches right away anyway, but that doesn't matter. My point about whitespace was not that it is a critical issue at this point, but something I think should be cleaned before inclusion. git would make it trivial to do (this early) so I think it's a good idea. I'm afraid I'm unable to review the patches in greater depth. :\ //Peter
