> -----Original Message----- > From: David Sommerseth [mailto:openvpn.l...@topphemmelig.net] > Sent: vrijdag 10 december 2010 8:56 > To: Adriaan de Jong > Cc: Peter Stuge; openvpn-devel@lists.sourceforge.net > Subject: Re: [Openvpn-devel] [Patch] OpenVPN PolarSSL Support Preview > [7/8] > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 10/12/10 08:38, Adriaan de Jong wrote: > > About the whitespace: it's a tad difficult to split the patches now. > Are you sure it wouldn't be acceptable this way? > > > If I'm not entirely mistaken, these patches are based against a 2.1.x > release and not the git tree at all. Considering that we're in the > midst of getting the official 2.2 release out-the-door in about a month > or so, I'd suggest that we primarily do code review now. > > Adriaan can then rebase these patches against the git tree when I get > the beta2.2 branch stabilised as a release branch. In this process, > I'd > expect Adriaan to also implement our review comments as well. I've > discussed this with Adriaan on IRC already, and this seemed to me that > this is what he would prefer. > > Since this is a big round of patches, I do expect merge conflicts > applying these patches unto the beta2.2 branch. Which means, Adriaan > needs to rebase his patches anyway. > > So, please high-light coding style issues so that he can fix that for > the final round for the final inclusion into our git tree. But lets > first of all this be a code review round so that Adriaan got something > to work to get the final inclusion go smoother in the end. > > Adriaan, will this work for you? Any other comments or thoughts? > > > kind regards, > > David Sommerseth > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ > > iEYEARECAAYFAk0B3RoACgkQDC186MBRfrp/nACglVEbUxG9n0Bp3Ttz2BDWgxkL > ywoAnj6uCCeTMKLZ5vfAknS1M7HUWqjI > =d4Sp > -----END PGP SIGNATURE-----
That's exactly what I was hoping for. I've tried to stay within any coding standards that I could find within the code. I'm making a note of any comments people have, and will include them in the actual 2.2 git rebase. As soon as that's done I can start making use of the other git commands. Kind regards, Adriaan
