-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/06/10 00:49, Matthias Andree wrote: > Hi, > > based on a FreeBSD problem report, I am attaching a patch against the > 2.1 branch to remove a bashism (source FILE needs to become . FILE) and > switch the shebang lines to /bin/sh.
Thank you very much for your patch! > Note that some parts of the scripts may be Solaris /bin/sh unfriendly, > for instance, Solaris's sh doesn't support test -e or [ -e. My patch > does not address this. This makes me very reluctant from accepting the patch, to be very honest. I'd rather keep the current bashism which works on all platforms where bash is available than to apply a patch which will break the script from working on one of the supported platforms. I would rather like to see a patch which works safely on all platforms. If 'test -e' or '[ -e' does not work in /bin/sh on some platforms, that do indeed speak for keeping the bash support - unless there are other ways how to solve this issue. kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkwKsikACgkQDC186MBRfrqlGwCffs/zQP5ZKmYD7mMlT9rse4TB ml4AoIxTVVpKHnOJgMNDKPFaCSHdGb6D =ACWx -----END PGP SIGNATURE-----
