On 05/30/2009 05:30:09 AM, James Yonan wrote:
I would rather not have touched cryptoapi.c for rc16, but it wouldn't
build with MinGW 5.1.4 (the .h files in this version of MinGW define
the
symbol CryptAcquireCertificatePrivateKey which conflicts with the
symbol
of the same definition in cryptoapi.c).  So I did try to work around
the
issue, but perhaps I broke something in the process.

It would be great if one of the developers that uses the crypto API
feature could take a look at it.  We will certainly accept a patch
that
fixes any introduced breakage.

From my post:
http://sourceforge.net/mailarchive/message.php?msg_name=1239152310l.18482l.7l%40mofo

--------<snip>------------
One issue is that cryptoapi.c works around a
problem where CryptAcquireCertificatePrivateKey
is missing from MinGW.  However, I've installed
the latest stable MinGW, 5.1.4, and the function
is now in MinGW.  So, I tried commenting out the
#ifdef __MINGW32_VERSION hacks in cryptoapi.c.
This seems to have worked.  (So far)
--------<snip>------------

The above works.  In other words there's a bunch
of extra code in cryptoapi.c that no longer needs
to be there, at least with the latest MinGW.
To retain compatibility with older MinGW versions
the right thing to do is conditional compilation
based on the MinGW version, or maybe there's another
approach that would work better.  I've not looked
at the code in a while.

Back when I was looking at getting OpenVPN
to compile under MinGW I might have sent a patch
to this list but
I've already sent 3 patches and gotten no feedback
whatsoever from anybody who seems to be a
maintainer so I don't really see the point in
trying to contribute.



James

Alon Bar-Lev wrote:
> True.
> I already reported this to James.
> There were too many change-replace at the cryptoapi.c in this
version.
>
> On Fri, May 29, 2009 at 2:09 PM, Markus Bickel
<zerocool.2...@gmx.de> wrote:
>> Dear developers,
>>
>> I'm currently installing and testing OpenVPN 2.1 on windows
environment and have seen that there's a newer version rc16.
>>
>> Since this version I cannot use the parameter:
>>
>> --cryptoapicert "Thumb:xx xx xx xx xx"
>>
>> Error message:
>>
>> cannot load certificate "Thumb:xx xx xx xx .... " from Microsoft
Certificate Store:
>> error:C506C064:microsoft cryptoapi:GetProcAddress:The specified
procedure could not be found.
>>
>>
>> This behaviour is the same on server or client sides.
>> With rc15 this worked well.
>>
>> Maybe this is a small bug.
>> So I want to report this issue to you.
>>
>> Would it be fixed in rc17?
>>
>> Thanks in Adanvce,
>>
>> Markus
>>
>> --
>> Nur bis 31.05.: GMX FreeDSL Komplettanschluss mit DSL 6.000
Flatrate und
>> Telefonanschluss nur 17,95 Euro/mtl.!*
http://portal.gmx.net/de/go/dsl02
>>
>> ------------------------------------------------------------------------------
>> Register Now for Creativity and Technology (CaT), June 3rd, NYC.
CaT
>> is a gathering of tech-side developers & brand creativity
professionals. Meet
>> the minds behind Google Creative Lab, Visual Complexity,
Processing, &
>> iPhoneDevCamp as they present alongside digital heavyweights like
Barbarian
>> Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
>> _______________________________________________
>> Openvpn-devel mailing list
>> Openvpn-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>>
>
> ------------------------------------------------------------------------------
> Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT

> is a gathering of tech-side developers & brand creativity
professionals. Meet
> the minds behind Google Creative Lab, Visual Complexity, Processing,
&
> iPhoneDevCamp as they present alongside digital heavyweights like
Barbarian
> Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel


------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity
professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &

iPhoneDevCamp as they present alongside digital heavyweights like
Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel




Karl <k...@meme.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Reply via email to