Alon Bar-Lev wrote:

Subject: Fix for "Cannot read current default gateway" problem on Linux

> On Monday 02 February 2009 11:49:50 David Balazic wrote:
> > diff -u openvpn_trunk/route.c openvpn_patched/route.c
> > --- openvpn_trunk/route.c   2009-01-29 15:00:04.525034400 +0100
> > +++ openvpn_patched/route.c 2009-01-29 15:03:41.116012000 +0100
> > @@ -45,7 +45,7 @@
> >  
> >  static void add_route (struct route *r, const struct 
> tuntap *tt, unsigned int flags, const struct env_set *es);
> >  static void delete_route (const struct route *r, const 
> struct tuntap *tt, unsigned int flags, const struct env_set *es);
> > -static bool get_default_gateway (in_addr_t *ret);
> > +static bool get_default_gateway (in_addr_t *ret, char *gw_if_name);
> >  
> >  struct route_option_list *
> >  new_route_option_list (struct gc_arena *a)
> 
> Which version of diffutils do you use?
> How come there is a tab after file name in the header?

Well, I asked and it seems to be the normal state of things:


    * From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
    * To: cygwin at cygwin dot com
    * Date: Mon, 2 Feb 2009 17:56:10 +0000
    * Subject: Re: diff inserts tab into header ?
    * References: <worldclient-f200902021754.aa54240...@butn.net>

xerces8 wrote:
>>> I discovered this when trying to send a patch to a project and
>>> they rejected it because of this tab chars.
>> Are you sure this is the case? Can you send the exact message they
sent
>> you when they rejected the patch?
>
> Sure, they said this:
>
>>> Which version of diffutils do you use?
>>> How come there is a tab after file name in the header?

  They must be using a custom version or something strange like that.
The
TAB is placed there by the routine 'print_context_label()' in context.c,
you
can view the CVS history at

http://cvs.savannah.gnu.org/viewvc/diffutils/src/context.c?root=diffutil
s&view=log

and it's been right there since version 1.1, seventeen years ago (see
line 46).

  So AFAICT GNU diff has /always/ done this.


Regards,
David

Reply via email to