I know that many open source projects ask for patches to be submitted
inline, rather than via email attachment. Quite honestly, I don't think
this approach works in practice. Many email clients in popular use will
munge the patch making it unusable. This creates a hassle for the
maintainers as they must request the patch to be resubmitted.
I know that in the past, the OpenVPN Project has echoed the common
practice of asking for patches to be submitted inline. I would like to
change that practice now. So please, in the future, submit patches as
attachments. For trivial patches, it's okay paste them inline for
discussion purposes as long as they are also included as an attachment.
Thanks,
James
Alon Bar-Lev wrote:
On Monday 02 February 2009 11:49:50 David Balazic wrote:
diff -u openvpn_trunk/route.c openvpn_patched/route.c
--- openvpn_trunk/route.c 2009-01-29 15:00:04.525034400 +0100
+++ openvpn_patched/route.c 2009-01-29 15:03:41.116012000 +0100
@@ -45,7 +45,7 @@
static void add_route (struct route *r, const struct tuntap *tt, unsigned int flags, const struct env_set *es);
static void delete_route (const struct route *r, const struct tuntap *tt,
unsigned int flags, const struct env_set *es);
-static bool get_default_gateway (in_addr_t *ret);
+static bool get_default_gateway (in_addr_t *ret, char *gw_if_name);
struct route_option_list *
new_route_option_list (struct gc_arena *a)
Which version of diffutils do you use?
How come there is a tab after file name in the header?
How come the above hank has 8 lines but reported as 7 lines?
Alon.
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
