On 2015-09-28 11:47, Gorka Eguileor wrote:
On 26/09, Morgan Fainberg wrote:
As a core (and former PTL) I just ignored commit message -1s unless there is
something majorly wrong (no bug id where one is needed, etc).
I appreciate well formatted commits, but can we let this one go? This
discussion is so far into the meta-bike-shedding (bike shedding about bike
shedding commit messages) ... If a commit message is *that* bad a -1 (or just
fixing it?) Might be worth it. However, if a commit isn't missing key info (bug
id? Bp? Etc) and isn't one long incredibly unbroken sentence moving from topic
to topic, there isn't a good reason to block the review.
It is not worth having a bot -1 bad commits or even having gerrit muck with
them. Let's do the job of the reviewer and actually review code instead of
going crazy with commit messages.
Sent via mobile
I have to disagree, as reviewers we have to make sure that guidelines
are followed, if we have an explicit guideline that states that
the limit length is 72 chars, I will -1 any patch that doesn't follow
the guideline, just as I would do with i18n guideline violations.
> [...]
You could also tell the committer about the length so that s/he learns
for the next time. Giving a -1 just for a few lines that are 80 chars
long is over the top IMHO,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
