Another option... why are we wasting time on something that a computer can handle? Why not just let the line length be infinite in the commit message and have gerrit wrap it to <insert random number here> length lines on merge?
Thanks, Kevin ________________________________________ From: Jim Rollenhagen [j...@jimrollenhagen.com] Sent: Friday, September 25, 2015 8:42 AM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [all] -1 due to line length violation in commit messages On Fri, Sep 25, 2015 at 04:44:59PM +0200, Ihar Hrachyshka wrote: > Hi all, > > releases are approaching, so it’s the right time to start some bike shedding > on the mailing list. > > Recently I got pointed out several times [1][2] that I violate our commit > message requirement [3] for the message lines that says: "Subsequent lines > should be wrapped at 72 characters.” > > I agree that very long commit message lines can be bad, f.e. if they are 200+ > chars. But <= 79 chars?.. Don’t think so. Especially since we have 79 chars > limit for the code. > > We had a check for the line lengths in openstack-dev/hacking before but it > was killed [4] as per openstack-dev@ discussion [5]. > > I believe commit message lines of <=80 chars are absolutely fine and should > not get -1 treatment. I propose to raise the limit for the guideline on wiki > accordingly. > > Comments? It makes me really sad that we actually even spend time discussing things like this. As a core reviewer, I would just totally ignore this -1. I also ignore -1s for things like minor typos in a comment, etc. Let's focus on building good software instead. :) // jim __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
