On Mon, Jul 14, 2014 at 11:01:17AM -0500, Kevin L. Mitchell wrote: > On Sat, 2014-07-12 at 12:46 -0400, Jay Pipes wrote: > > > Given that we have so many old reviews hanging around on nova (and > > > probably other projects), should we consider setting something like that > > > back up? With nova, at least, the vast majority of them can't possibly > > > merge because they're so old, so we need to at least have something to > > > remind the developer that they need to rebase…and if they've forgotten > > > the review or don't care about it anymore, we should either have it > > > taken over or get the review abandoned. > > > > I didn't like the impersonal nature of the auto-expire thing, frankly. I > > prefer the current situation where deliberate action is needed, even if > > that means a little more work for the core review team. > > Hmmm…I can see that, but it seems like there's very little deliberate > action going on here :) It's possible that reviewers are just not aware > yet that auto-expire doesn't exist anymore and deliberate action is > necessary…
Indeed, I don't recall anyone telling Nova cores developers that we should be manually "expiring" patches, so I've not tried to expire any myself. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
