On Fri, 16 Dec 2016 11:14:59 -0800, Richard Nelson wrote: > FWIW, those particular units types were introduced as part of the LLTrace > metrics update and found several cases where the incorrect units were > being recorded, resulting in skewed/invalid metrics. The point is not > that it is hard to multiply by a constant to do unit conversion...it is > that programmers sometimes forget to, so it is hard to know how much you > can trust metrics that have not been thoroughly vetted in the code.
The guy with the anvil and the hammmer had a good reason too. :-D I would have solved this issue differently, e.g. by ensuring all variables used in the viewer code classes to track down memory usage use the same "unit" (more like a multiple, here), such as bytes in S64 variables (or kilobytes in S32), then also making sure all those variables names bear the unit (multiple) name in their own name (e.g.: mTextureMemoryBytes). With a comment or two in appropriate locations in the stats sending methods, stating what units are to be used, this would have covered both current and future usages of memory tracking for coders. Henri. _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
