----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/570/#review1209 -----------------------------------------------------------
Ship it! Ship It! - Oz Linden On April 3, 2012, 6:37 p.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/570/ > ----------------------------------------------------------- > > (Updated April 3, 2012, 6:37 p.m.) > > > Review request for Viewer and Oz Linden. > > > Description > ------- > > Sometimes the file character/new archetype.xml is not produced. Sometimes it > is present after the viewer is closed. Sometimes it is present and can't be > made to fail. > > Intermittent write to character/new archetype.xml from Develop->Avatar-> > Character Tests->Apperance To XML. Add explicit outfile.close() method > before returning to caller. Add llinfos for file location as a troubleshooting > aid. > > > This addresses bug STORM-1828. > http://jira.secondlife.com/browse/STORM-1828 > > > Diffs > ----- > > doc/contributions.txt 6943d3e9deb7 > indra/newview/llvoavatar.cpp 6943d3e9deb7 > > Diff: http://codereview.secondlife.com/r/570/diff/diff > > > Testing > ------- > > First checked that the patch did no harm. > Second seems more stable after running with the patch applied. > ***** > Tested the file write in a development and installed configurations. Repeated > Develop->Avatar-> > Character Tests->Apperance To XML several times while watching the time file > time stamp. > No failures were noted. > > > Thanks, > > Nicky Perian > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
