> On Aug. 7, 2011, 2:10 p.m., Vadim ProductEngine wrote: > > indra/newview/viewer_manifest.py, line 208 > > <http://codereview.secondlife.com/r/427/diff/5/?file=6908#file6908line208> > > > > Shouldn't the regexp start with a caret (which denotes beginning of the > > line) ?
the re.match python function only matches at the beginning of the value. If I had used re.search, the caret would have been needed. - Oz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/427/#review955 ----------------------------------------------------------- On Aug. 6, 2011, 6:14 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/427/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2011, 6:14 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > In the Help>About Second Life dialog, there are lists of users who have > contributed to the viewer and provided translations. Prior to this change, > those lists had to be updated manually (and had not been updated in quite > some time). > > Since we have a separate file (doc/contributions.txt) to track contributions, > and it is in an easily parseable format, this change modifies the viewer > build to construct a file (app_settings/contributors.txt) containing those > names, and another for the translators (app_settings/translators.txt) from a > new doc/translations.txt file (the contents of which are not complete in this > patch, but are sufficient for review and testing purposes). > > I also removed the list of Lindens from the dialog, as it too had not been > updated in a long time and replaced it with a more generic statement. > > > This addresses bug storm-1534. > http://jira.secondlife.com/browse/storm-1534 > > > Diffs > ----- > > doc/contributions.txt 3b734a58e7a6 > doc/translations.txt PRE-CREATION > indra/newview/llfloaterabout.cpp 3b734a58e7a6 > indra/newview/skins/default/xui/en/floater_about.xml 3b734a58e7a6 > indra/newview/viewer_manifest.py 3b734a58e7a6 > > Diff: http://codereview.secondlife.com/r/427/diff > > > Testing > ------- > > So far built and tested only locally on my Mac... will set up a TeamCity > build for other platforms shortly and add a pointer here. See screenshot on > the jira issue. > > > Thanks, > > Oz > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
