-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/427/
-----------------------------------------------------------
(Updated Aug. 3, 2011, 2:58 p.m.)
Review request for Viewer.
Changes
-------
Modified code to load dynamic Lindens list provided at build time if available,
and use the static value from the xui if not.
Further build changes needed to fetch that Linden list at build time.
Summary
-------
In the Help>About Second Life dialog, there are lists of users who have
contributed to the viewer and provided translations. Prior to this change,
those lists had to be updated manually (and had not been updated in quite some
time).
Since we have a separate file (doc/contributions.txt) to track contributions,
and it is in an easily parseable format, this change modifies the viewer build
to construct a file (app_settings/contributors.txt) containing those names, and
another for the translators (app_settings/translators.txt) from a new
doc/translations.txt file (the contents of which are not complete in this
patch, but are sufficient for review and testing purposes).
I also removed the list of Lindens from the dialog, as it too had not been
updated in a long time and replaced it with a more generic statement.
This addresses bug storm-1534.
http://jira.secondlife.com/browse/storm-1534
Diffs (updated)
-----
doc/contributions.txt 3b734a58e7a6
doc/translations.txt PRE-CREATION
indra/newview/llfloaterabout.cpp 3b734a58e7a6
indra/newview/skins/default/xui/en/floater_about.xml 3b734a58e7a6
indra/newview/viewer_manifest.py 3b734a58e7a6
Diff: http://codereview.secondlife.com/r/427/diff
Testing
-------
So far built and tested only locally on my Mac... will set up a TeamCity build
for other platforms shortly and add a pointer here. See screenshot on the jira
issue.
Thanks,
Oz
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
