> On Jan. 19, 2011, 2:44 p.m., Boroondas Gupte wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > <http://codereview.secondlife.com/r/90/diff/1/?file=413#file413line1595> > > > > Old code: > > validate_idx will now be in [1,256]. (one higher than before) > > > > New code: > > validate_idx will stay in [0,256]. (untouched) > > > > Old and new code: > > next_idx will be in [0,256], but different than the new-code > > validate_idx (one higher modulo 256).
ok, tripple checked the ranges, but still typed them wrong ... this should be New code: validate_idx will stay in [0,255]. (untouched) Old and new code: next_idx will be in [0,255], but different than the new-code validate_idx (one higher modulo 256). > On Jan. 19, 2011, 2:44 p.m., Boroondas Gupte wrote: > > indra/newview/lltexturecache.cpp, lines 1596-1598 > > <http://codereview.secondlife.com/r/90/diff/1/?file=413#file413line1596> > > > > next_idx (still in the range [0,256]) gets saved to setting. (Thus why > > the value we get from the setting above must be in that interval.) make this [0,255], too ^_^ - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review199 ----------------------------------------------------------- On Jan. 14, 2011, 1:02 p.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/90/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2011, 1:02 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Trivial patch, just removes stupidity. > > > This addresses bug VWR-24321. > http://jira.secondlife.com/browse/VWR-24321 > > > Diffs > ----- > > doc/contributions.txt b0bd26c5638a > indra/newview/lltexturecache.cpp b0bd26c5638a > > Diff: http://codereview.secondlife.com/r/90/diff > > > Testing > ------- > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
