> On Jan. 19, 2011, 2:44 p.m., Boroondas Gupte wrote: > > > validate_idx being used in a test later, it's not just for (validate_idx > > > == 0) > > > that the behavior will be different. I need to understand better what > > > that idx > > > is all about or you need to give a bit more explanation before I approve > > > this diff. > > > > The different intention is needed. Without the change Aleric suggests, > > files that have a specific byte of their UUID being 0 will never be > > validated. On the other hand, sometimes no files will be tested at all > > (when validate_idx is 256, as no byte can assume that value).
> The different intention is needed. Err ... I mean "The different behavior is intentional (and needed)." - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review199 ----------------------------------------------------------- On Jan. 14, 2011, 1:02 p.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/90/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2011, 1:02 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Trivial patch, just removes stupidity. > > > This addresses bug VWR-24321. > http://jira.secondlife.com/browse/VWR-24321 > > > Diffs > ----- > > doc/contributions.txt b0bd26c5638a > indra/newview/lltexturecache.cpp b0bd26c5638a > > Diff: http://codereview.secondlife.com/r/90/diff > > > Testing > ------- > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
