On Thu, Jun 9, 2011 at 10:57 PM, Andreas Fritiofson
<andreas.fritiof...@gmail.com> wrote:
> ft2232_init really refers to init of the openocd driver, while
> ft2232_init_{libftdi,ftd2xx} refers to init of the ftdi subsystem including
> hardware (using either of the libraries). Different inits, hence "one" and
> "all" is not the suitable distinction. How about ft2232_init_ftdi that could
> be interpreted as initializing the ftdi library, the ftdi chip or the ftdi
> handle, all of which are true?

The current organization for me is okay - there is a standard
ft2232_init() function that call ft2232_init_ftdi() if the program was
built with libftdi or ft2232_init_ftd2xx() if the program was built
with libftd2xx. There is no need to complicate this behavior as
exactly the complication was the problem with previous patches.

Please remember guys also to properly fix the ft2232_quit() as Laurent
proposed, this is also necessary to bring interface to default state
on quit :-)

Gotos are okay in presented case where avoiding gotos bring
unnecessary complication.

Best regards! :-)
Tomek

-- 
CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to