Andreas Fritiofson wrote: > > + retval = ft2232_initone(ft2232_vid[i], ft2232_pid[i], more, > > &try_more); > > > > This is a good start, but what's with the function name??
Short. And one from one device. As opposed to try to init *all* supported devices, which is what ft2232_init does. > Another ugliness in my point of view is using the try_more parameter Oh for sure. It was like that when I came here. Maybe small steps is a good idea. Please do send more patches to do further cleanup. > Seems the message belongs outside the function, making the > parameter useless. Note that I know nothing of the code style in OpenOCD. At least the ft2232 driver seems to consistently output error messages at the lowest level in the call stack, as opposed to letting the highest level (user interface) determine how the error should be handled. I found this quite awkward, but I wanted to make changes that were already some improvements over what was there. I am not saying the patches make things perfect, there's certainly still more to do! //Peter _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
