On Tue, May 17, 2011 at 10:16 PM, Øyvind Harboe <oyvind.har...@zylin.com> wrote:
>
> Good work!
>
> I think your chances of getting help on this one would
> improve if we get this into the official repository first.
>
> If your code is well tested, I'm inclined to commit it as-is as
> a starting point to make improvements and get testing going.
thanks!
the plan sounds great! :)
i've been working on this a lot, no too quick since i'm learning on
the go and go again and again and again :)
i'm going to keep dedicating a lot of time to this. i've tested it a
lot, there's still a lot to do.
it would be really good to get this into openocd, i think things would
go much smoother with support from the community.
the first thing i want to do is to get flashing to run at a reasonable speed.
the chip has a lot of debugging support, so there's stuff to do in that area.
> A general comment about error messages. The error
> should be reported where it occurred and not after
> the fact(modeled on exceptions) and then the error
> message should be propagated.
>
> I.e. a number of the err_check() should only propagate the
> error and not add an error message as the error has already
> been reported.
>
> You'd have to search through your code, but below I would
> consider using a macro to only propagate and not to
> amend any information.
>
> + retval = dsp5680xx_jtag_status(target,&jtag_status);
> + err_check(retval,"Failed to get JTAG status.");
>
>
> Something like this?
>
> #define err_check_propagate(retval,err_msg) if(retval !=
> ERROR_OK){return retval;}
>
i'll modify the macro to get that behavior.
thanks!
--
Rodrigo.
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
