Good work!
I think your chances of getting help on this one would
improve if we get this into the official repository first.
If your code is well tested, I'm inclined to commit it as-is as
a starting point to make improvements and get testing going.
A general comment about error messages. The error
should be reported where it occurred and not after
the fact(modeled on exceptions) and then the error
message should be propagated.
I.e. a number of the err_check() should only propagate the
error and not add an error message as the error has already
been reported.
You'd have to search through your code, but below I would
consider using a macro to only propagate and not to
amend any information.
+ retval = dsp5680xx_jtag_status(target,&jtag_status);
+ err_check(retval,"Failed to get JTAG status.");
Something like this?
#define err_check_propagate(retval,err_msg) if(retval !=
ERROR_OK){return retval;}
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
