Øyvind Harboe wrote: > I think it would be a good idea to have -Wshadow enabled by > default, it has uncovered several real bugs w.r.t. retval > today. > Agreed. > Three options come to mind: > > 1. don't enable it and wait for bugs to appear and fix them > one by one, possibly without -Wshadow help as those that > run into these bugs won't think of enabling -Wshadow > Not really helpful. > 2. enable it to try to force the community to submit fixes. > The disadvantage is that community could turn off > all -Werror and we'll get fewer patches on fixing warnings > 3. encourage the community to enable -Wshadow and submit > patches. > > Currently we're at #1. > I think #3 sounds good (and turn on -Wshadow by default as soon as we have reached a warning-free state - how many of those warnings are there currently?)
cu Michael _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
