I think it would be a good idea to have -Wshadow enabled by default, it has uncovered several real bugs w.r.t. retval today.
However, there are *many* places that need to be fixed in the code for openocd to build without any -Wshadow warnings. Three options come to mind: 1. don't enable it and wait for bugs to appear and fix them one by one, possibly without -Wshadow help as those that run into these bugs won't think of enabling -Wshadow 2. enable it to try to force the community to submit fixes. The disadvantage is that community could turn off all -Werror and we'll get fewer patches on fixing warnings 3. encourage the community to enable -Wshadow and submit patches. Currently we're at #1. -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
