On Tue, Jan 12, 2010 at 10:54 PM, David Brownell <davi...@pacbell.net> wrote:
> On Monday 11 January 2010, Øyvind Harboe wrote:
>> --- a/src/target/arm7_9_common.c
>> +++ b/src/target/arm7_9_common.c
>> @@ -2723,6 +2723,17 @@ int arm7_9_examine(struct target *target)
>> return retval;
>> }
>>
>> +
>> +int arm7_9_check_reset(struct target *target)
>> +{
>> + struct arm7_9_common *arm7_9 = target_to_arm7_9(target);
>> +
>> + if (!arm7_9->dcc_downloads)
>> + {
>> + LOG_WARNING("NOTE! DCC downloads have not been enabled,
>> defaulting to slow memory writes. Type 'help dcc'.");
>
> The thing that bothers me about this is that it'll appear after EVERY
> reset, so it's a pretty annoying nag message ... I think nags should
> be consistent, but *MUCH* lower volume than that. Nothing is actually
> wrong, after all...
>
> Could you add a boolean to the arm7_9 struct to control whether it should
> nag about this or not? Then set it to "no nag" after nagging once.
I'm more inclined towards adding a command to silence this nagging. That
way the author of the config script has confirmed that he knows about
the issue.
> Also, DCC depends on getting a working area, so testing that flag alone
> is insufficient; you'd need to check that too. Working area is of
> course more widely useful than DCC; check for that first, nag at most
> once, and then only check for DCC if some working area is available.
The actual checks will have to be refined for sure and would probably
vary across targets.
--
Øyvind Harboe
US toll free 1-866-980-3434 / International +47 51 63 25 00
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
