On Monday 11 January 2010, Øyvind Harboe wrote:
> --- a/src/target/arm7_9_common.c
> +++ b/src/target/arm7_9_common.c
> @@ -2723,6 +2723,17 @@ int arm7_9_examine(struct target *target)
> return retval;
> }
>
> +
> +int arm7_9_check_reset(struct target *target)
> +{
> + struct arm7_9_common *arm7_9 = target_to_arm7_9(target);
> +
> + if (!arm7_9->dcc_downloads)
> + {
> + LOG_WARNING("NOTE! DCC downloads have not been enabled,
> defaulting to slow memory writes. Type 'help dcc'.");
The thing that bothers me about this is that it'll appear after EVERY
reset, so it's a pretty annoying nag message ... I think nags should
be consistent, but *MUCH* lower volume than that. Nothing is actually
wrong, after all...
Could you add a boolean to the arm7_9 struct to control whether it should
nag about this or not? Then set it to "no nag" after nagging once.
Also, DCC depends on getting a working area, so testing that flag alone
is insufficient; you'd need to check that too. Working area is of
course more widely useful than DCC; check for that first, nag at most
once, and then only check for DCC if some working area is available.
- Dave
> + }
> +}
> +
> COMMAND_HANDLER(handle_arm7_9_dbgrq_command)
> {
> struct target *target = get_current_target(CMD_CTX);
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
