On Tuesday 12 January 2010, Spencer Oliver wrote:
> - add mips support for target algorithms.
> - added handlers for target_checksum_memory and target_blank_check_memory.
>
> Signed-off-by: Spencer Oliver <ntfr...@users.sourceforge.net>
At first glance, this sounds more like new-feature than bug-fix;
but right now we want to avoid merging features.
Does this fix any bugs? I don't know the MIPS stuff; it almost
seems like the CFI support would suffer badly from lack of support
for those handlers... If so, the patch comment should highlight
what now works correctly, not just the new mechanism that's used to
achieve the fixes.
- Dave
p.s. I noticed a few lines of 100+ characters; please shrink.
Otherwise the code looked pretty clean; "oddly familiar"
in some ways ... ;)
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
