Austin, Alex wrote: >> -----Original Message----- >> From: openocd-development-boun...@lists.berlios.de [mailto:openocd- >> development-boun...@lists.berlios.de] On Behalf Of Øyvind Harboe >> Sent: Thursday, December 24, 2009 1:09 AM >> To: Austin, Alex >> Cc: Laurent Gauch; openocd-development@lists.berlios.de >> Subject: Re: [Openocd-development] [patch/rfc] Add support for >> multiple-ports on FT4232H >> >> >>> I could probably do this, but supporting the 4232 is time I can bill >>> >> to >> >>> my company, while driver refactoring is not (yet). >>> >> Why should the community take on cleanup and refactoring work >> to support your company's patch? >> >> > > The refactor is not to support our patch, just to clean up the ft2232 > driver. My comment is in response to something that was said should > probably be done anyway, not specifically to support our device. I > think support for our device could be done without said refactor, but > the code would be uglier-yet and you would be unlikely to accept it. > Hi Austin,
Every new hardware are welcome to OpenOCD project. More products, more ideas, more code, more productivity. But your new product cannot be added in the FT2232.c without adding regression speed, and concept regression. Small regression, but regression. The idea of the JTAG and Debug port over FT2232 as with the Amontec JTAGkey ( now JTAGkey-2, in 2010 JTAGkey-3 ), is to use one port for JTAG / RTCK / TRST / RESET signal / EMUx signal ... But with the FT4232 you cannot do this without calling an other USB port (from the composite USB FT4232) for getting enough IO signals. Also, calling a new port in the ft2232.c IS NOT the way to go, since you will need to add more conditional code in the ft2232.c ... adding regression, and future bugs since you are calling two USB handle ... The quicker to do : 1. Create a new ft4232.c jtag driver file, and call some functions from ft2232 if needed. The best to do: 2. Split the actual ft2232.c to two file ft2232_new.c and mpsse.c . Then Austin could call funtions from mppse.c. When all is working we will rename ft2232_new.c to ft2232.c. Finally we will have : ft2232.c ft4232.c mpsse.c The 2. is the good way to go. Regards, Laurent http://www.amontec.com Low cost JTAG Debugger solutions Amontec JTAGkey ( Tiny -2 -2P ) Based on FTDI ft2232 devices since 2005 ! _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
