On Saturday 19 December 2009, Dean Glazeski wrote:
> > Could you reissue this without the gratuitous "add semicolon" changes?
> > That way we'll be able to see if significant changed...
>
> I can make this change later, but I thought that was actually valid TCL. 

http://wiki.tcl.tk/963 "When are semicolons stylistically appropriate?"

But it's not appropriate for a patch that's about adding NAND support.


> I saw somewhere that end of line comments like that need to have the
> semicolon.  In fact, my editor refuses to highlight the comments as comments
> unless I have that semicolon in place.

I tend to just not use partial-line comments in Tcl.  :)

If you want to update that file to use those, it would be
much less confusing to change that in a separate patch.

- Dave

p.s. http://wiki.tcl.tk/963 "When are semicolons stylistically appropriate?"



_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to