On Thursday 17 December 2009, Dean Glazeski wrote:
> +...@deffn Command {at91sam9 cle} num addr_line
So "addr_line" is for example "8" to indicate that A8 is
used to drive the CLE signal? Or should that be 0x0100
instead?
And ... are there defaults, or are ALE and CLE "must specify"
things? If the latter ... are they shared between all the
various NANDs of $TARGET, or is there some other reason these
two aren't parameters to "nand device ..."? It'd be good to
avoid extra commands, as well as the potential failure modes
from someone not providing those parameters.
> + target_write_u8(target, info->cmd, command);
> +
> + return ERROR_OK;
Why not "return target_write_u8(...)" etc?
As a rule, you should be returning status codes from
routines you've called, not ERROR_OK.
> +static int at91sam9_write_data(struct nand_device *nand, uint16_t data) {
That's not a struct decl, or a switch/for/if/while/do/... control
flow construct. So the brace should be at the beginning of the
next line. :)
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
