On Fri, 2009-11-27 at 12:47 -0800, David Brownell wrote:
> On Friday 27 November 2009, Zach Welch wrote:
> > > And what might have caused "nand list" output to repeat?  As if
> > > the command got called twice...
> 
> Saw the same with "arm reg".  Do all commands repeat their output?

All not-top-level commands, yes.  I will post the fix shortly.

> > > > nand list
> > > #0: NAND 1GiB 3,3V 8-bit (Micron) pagesize: 2048, buswidth: 8,
> > >       blocksize: 131072, blocks: 8192
> > > #1: NAND 1GiB 3,3V 8-bit (Micron) pagesize: 2048, buswidth: 8,
> > >       blocksize: 131072, blocks: 8192
> > > #0: NAND 1GiB 3,3V 8-bit (Micron) pagesize: 2048, buswidth: 8,
> > >       blocksize: 131072, blocks: 8192
> > > #1: NAND 1GiB 3,3V 8-bit (Micron) pagesize: 2048, buswidth: 8,
> > >       blocksize: 131072, blocks: 8192
> > > 
> > > > exit
> > > 
> > 
> > Great question.  I'll look at this regression, though it looks like that
> > command "wants" to return the same format as the 'flash banks' command
> > (i.e. as a list that can be further manipulated in TCL).
> 
> Didn't do so before...

Yup. :)

> > Would it be 
> > preferable to fix this issue by rewriting it in such terms?
> 
> As part of a wholesale effort to make sure every command's output can
> be manipulated in TCL, and to separately document the "native" format
> and the TCL-reformatters?  Sure.  But not just for this commands;
> let's just fix the regression.

Yeah.  That is a separate patch, for sure.

--Z

_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to