On Wed, 2009-11-11 at 08:40 +0100, Øyvind Harboe wrote: > I've read over the branch and improving types is always a good thing, > even if I don't have a specific opinions on whether to use > unsigned or int for iteration variables, etc.
There is almost always a correct choice. Most of the time, there is not really any opinion about it. There is correct and less-than-so. I mean really... this started with the annoyance of argc being 'int' rather than 'unsigned'. One can never have less than zero arguments, so.... IIRC, the fact that main() expects an 'int' reflects C's long legacy. There were too many out-of-tree users to worry about breaking things by the time unsigned came about, and so it was and shall ever be.... We can right such wrongs before we reach 1.0 and avoid suffering similar regrets in our future. > I don't like macros, but I see what you're trying to do here w.r.t. the > arguments for the command handler, so it seems like a reasonable > approach. Variadic macros (a part of C99) make it much better than it would have been in the old days. It is possible that my use of GCC's support for this feature goes beyond the standard, but I hope this does not turn out to be a problem. I'm not keen on hiding things with them. At the same time, it made the patches for changing the code paths _much_ cleaner. Thanks to the work already done, I have finished the list of tasks that I listed in my original post, and I have pushed the "final" series to my mirror. > What about Jim commands. Are you happy with them since you didn't > touch them? One thing at a time. Jim is... daunting from a cleaning perspective. At any rate, that suggests completely separate series of patches, but I have considered developing an unrelated package using Jim. Since its development pretty much happens here now, I might use cleanup as an excuse to start that project -- a "test suite" of sorts. Cheers, Zach _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
