On Thu, Jul 9, 2009 at 1:24 AM, David Brownell<davi...@pacbell.net> wrote: > On Wednesday 08 July 2009, Zach Welch wrote: >> The files in this series are meant for review, so feedback may be >> incorporated in them before I commit them. >> >> 1/5 Add comments to top-level files to "excuse" their Doxygen markup. >> 2/5 Add microscopic style guide at the end of the PATCH primer. >> 3/5 Add section to provide some documentation for cross-compiling. >> 4/5 Add style rule to avoid combining assignment and logical tests. >> 5/5 Document Maintainers and Testing. > > I'll ACK #s 1-4. > > #5 seems like two significant patches combined into one, > and they seem like they each need more review ...
If I were a maintainer (luckily or unluckily I am not), I would be a bit scared by the harsh/strict words in the Maintainers document considering the fact that all the maintainers and active contributors spend their free time to do free development... As for the test document part, I feel this sentence is a bit strange. "Users should never be asked to test the SVN.". Maybe this sentence itself is correct. But users will have to test the SVN after all since OpenOCD has not reached 1.0 stage and many bug fixes will have to be tested in SVN. -- Xiaofan http://mcuee.blogspot.com _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
