Switch integer types to use C99 portable types. Despite my previous preference for the existing types, the fact remains that the standard types offer sufficient advantages to compel their use. For example, the new number parsing helper functions use these secondary definitions to support range checking.
Unfortunately, these two type systems exhibit subtle incompatibilities, despite the fact that they should be fundamentally compatible. These patches fix this issue for the 0.2.0 release, helping to ensure OpenOCD can be built on as many platforms as possible. These patches result in the removal of the uN typedefs from types.h, changing all declarations using those types to the uintN_t types. It also updates the style documentation to reflect this policy. This series makes it possible to bisect for regressions with each of the types that was changed, with this second revision of the series spliting the changes into smaller pieces to also allow them to pass through the mailing list filters. Barring objections, this series will hit the repository within hours, as it should fix the warnings reported by Duane Ellis and Gene Smith. 1/11 Transform 'u8' to 'uint8_t' in src/target 2/11 Transform 'u8' to 'uint8_t' in src/flash 3/11 Transform 'u8' to 'uint8_t' 4/11 Transform 'u16' to 'uint16_t' 5/11 Transform 'u32' to 'uint32_t' in src/target/arm* 6/11 Transform 'u32' to 'uint32_t' in src/target 7/11 Transform 'u32' to 'uint32_t' in src/flash. 8/11 Finish transforming 'u32' to 'uint32_t'. 9/11 Transform 'u64' to 'uint64_t' 10/11 Remove redundant typedefs in types.h; include stdint.h unconditionally. 11/11 Update Style Guide documentation to explain basic type rules. --- Summary of Patches 1-11: doc/manual/style.txt | 7 src/flash/aduc702x.c | 48 +++--- src/flash/at91sam7.c | 102 ++++++------- src/flash/at91sam7.h | 46 +++--- src/flash/avrf.c | 40 ++--- src/flash/avrf.h | 2 src/flash/cfi.c | 184 ++++++++++++------------- src/flash/cfi.h | 126 ++++++++--------- src/flash/davinci_nand.c | 112 +++++++-------- src/flash/ecos.c | 44 +++--- src/flash/flash.c | 64 ++++---- src/flash/flash.h | 16 +- src/flash/lpc2000.c | 46 +++--- src/flash/lpc2000.h | 4 src/flash/lpc288x.c | 34 ++-- src/flash/lpc288x.h | 10 - src/flash/lpc3180_nand_controller.c | 64 ++++---- src/flash/lpc3180_nand_controller.h | 4 src/flash/mflash.c | 126 ++++++++--------- src/flash/mflash.h | 6 src/flash/nand.c | 106 +++++++------- src/flash/nand.h | 28 +-- src/flash/nand_ecc.c | 10 - src/flash/nand_ecc_kw.c | 4 src/flash/non_cfi.h | 18 +- src/flash/ocl.c | 16 +- src/flash/orion_nand.c | 26 +-- src/flash/pic32mx.c | 86 +++++------ src/flash/pic32mx.h | 4 src/flash/s3c2410_nand.c | 6 src/flash/s3c2440_nand.c | 14 - src/flash/s3c24xx_nand.c | 6 src/flash/s3c24xx_nand.h | 18 +- src/flash/stellaris.c | 58 +++---- src/flash/stellaris.h | 28 +-- src/flash/stm32x.c | 92 ++++++------ src/flash/stm32x.h | 10 - src/flash/str7x.c | 68 ++++----- src/flash/str7x.h | 14 - src/flash/str9x.c | 58 +++---- src/flash/str9x.h | 2 src/flash/str9xpec.c | 72 ++++----- src/flash/str9xpec.h | 4 src/flash/tms470.c | 72 ++++----- src/flash/tms470.h | 10 - src/helper/binarybuffer.c | 40 ++--- src/helper/binarybuffer.h | 30 ++-- src/helper/fileio.c | 26 +-- src/helper/fileio.h | 12 - src/helper/types.h | 66 +++------ src/jtag/amt_jtagaccel.c | 40 ++--- src/jtag/arm-jtag-ew.c | 44 +++--- src/jtag/at91rm9200.c | 16 +- src/jtag/bitbang.c | 6 src/jtag/bitq.c | 12 - src/jtag/commands.c | 10 - src/jtag/commands.h | 6 src/jtag/core.c | 44 +++--- src/jtag/driver.c | 14 - src/jtag/dummy.c | 2 src/jtag/ep93xx.c | 8 - src/jtag/ft2232.c | 132 +++++++++--------- src/jtag/gw16012.c | 24 +-- src/jtag/interface.c | 14 - src/jtag/jlink.c | 50 +++--- src/jtag/jtag.h | 42 ++--- src/jtag/minidriver.h | 14 - src/jtag/minidummy/jtag_minidriver.h | 4 src/jtag/minidummy/minidummy.c | 6 src/jtag/parport.c | 28 +-- src/jtag/presto.c | 24 +-- src/jtag/rlink/rlink.c | 54 +++---- src/jtag/rlink/rlink.h | 8 - src/jtag/rlink/rlink_speed_table.c | 8 - src/jtag/tcl.c | 10 - src/jtag/usbprog.c | 8 - src/jtag/vsllink.c | 102 ++++++------- src/jtag/zy1000/jtag_minidriver.h | 4 src/jtag/zy1000/zy1000.c | 16 +- src/pld/virtex2.c | 22 +-- src/pld/xilinx_bit.c | 4 src/pld/xilinx_bit.h | 14 - src/server/gdb_server.c | 64 ++++---- src/svf/svf.c | 52 +++---- src/target/algorithm.c | 4 src/target/algorithm.h | 14 - src/target/arm11.c | 100 ++++++------- src/target/arm11.h | 70 ++++----- src/target/arm11_dbgtap.c | 70 ++++----- src/target/arm720t.c | 36 ++-- src/target/arm720t.h | 8 - src/target/arm7_9_common.c | 166 +++++++++++----------- src/target/arm7_9_common.h | 48 +++--- src/target/arm7tdmi.c | 62 ++++---- src/target/arm920t.c | 104 +++++++------- src/target/arm920t.h | 22 +-- src/target/arm926ejs.c | 66 ++++----- src/target/arm926ejs.h | 16 +- src/target/arm966e.c | 22 +-- src/target/arm966e.h | 6 src/target/arm9tdmi.c | 62 ++++---- src/target/arm9tdmi.h | 10 - src/target/arm_adi_v5.c | 180 ++++++++++++------------ src/target/arm_adi_v5.h | 66 ++++----- src/target/arm_disassembler.c | 242 ++++++++++++++++----------------- src/target/arm_disassembler.h | 52 +++---- src/target/arm_jtag.c | 80 +++++----- src/target/arm_jtag.h | 44 +++--- src/target/arm_simulator.c | 60 ++++---- src/target/arm_simulator.h | 2 src/target/armv4_5.c | 26 +-- src/target/armv4_5.h | 4 src/target/armv4_5_cache.c | 2 src/target/armv4_5_cache.h | 4 src/target/armv4_5_mmu.c | 42 ++--- src/target/armv4_5_mmu.h | 12 - src/target/armv7m.c | 56 +++---- src/target/armv7m.h | 12 - src/target/avrt.c | 56 +++---- src/target/breakpoints.c | 10 - src/target/breakpoints.h | 20 +- src/target/cortex_a8.c | 22 +-- src/target/cortex_a8.h | 24 +-- src/target/cortex_m3.c | 110 +++++++-------- src/target/cortex_m3.h | 30 ++-- src/target/embeddedice.c | 48 +++--- src/target/embeddedice.h | 20 +- src/target/etb.c | 34 ++-- src/target/etb.h | 16 +- src/target/etm.c | 70 ++++----- src/target/etm.h | 36 ++-- src/target/feroceon.c | 56 +++---- src/target/image.c | 152 ++++++++++---------- src/target/image.h | 24 +-- src/target/mips32.c | 16 +- src/target/mips32.h | 12 - src/target/mips32_dmaacc.c | 64 ++++---- src/target/mips32_dmaacc.h | 16 +- src/target/mips32_pracc.c | 112 +++++++-------- src/target/mips32_pracc.h | 30 ++-- src/target/mips_ejtag.c | 26 +-- src/target/mips_ejtag.h | 14 - src/target/mips_m4k.c | 56 +++---- src/target/mips_m4k.h | 2 src/target/oocd_trace.c | 40 ++--- src/target/register.c | 4 src/target/register.h | 6 src/target/target.c | 256 +++++++++++++++++------------------ src/target/target.h | 64 ++++---- src/target/target_request.c | 16 +- src/target/target_request.h | 2 src/target/target_type.h | 26 +-- src/target/trace.c | 14 - src/target/trace.h | 16 +- src/target/xscale.c | 252 +++++++++++++++++----------------- src/target/xscale.h | 42 ++--- src/xsvf/xsvf.c | 56 +++---- 157 files changed, 3312 insertions(+), 3323 deletions(-) _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
