> >>> This patch looks OK to me. I'm in the middle of testing a bunch of >>> other SLAPI changes, so I will commit this once I have it tested >>> too. >> >>There's a macro, OPERATION_BUFFER_SIZE that computes the size required by >>an operation buffer which might be worth using; another good idea would >> be >>to create a helper (or a macro?) that nails things together, including >> the >>op->o_controls stuff, much like in connection_fake_init(). > > I will take a look. It looks like there are a bunch of other problems > that prevent SLAPI from working in HEAD... :-(
I'd suggest that a slapi-test be added to HEAD; I routinely compile with SLAPI enabled, but I haven't used it for a long time, so I didn't notice any inconvenience. You could add a trivial module that intercepts "all" occurrences of slapi calls and does something detectable, e.g. from the log files. This would provide some hints in keeping it working. p. -- Pierangelo Masarati mailto:[EMAIL PROTECTED] SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497
