>> This patch looks OK to me. I'm in the middle of testing a bunch of >> other SLAPI changes, so I will commit this once I have it tested >> too. > >There's a macro, OPERATION_BUFFER_SIZE that computes the size required by >an operation buffer which might be worth using; another good idea would be >to create a helper (or a macro?) that nails things together, including the >op->o_controls stuff, much like in connection_fake_init().
I will take a look. It looks like there are a bunch of other problems that prevent SLAPI from working in HEAD... :-( -- Luke --
