On Tue, 1 Sep 2026 22:09:17 GMT, Andy Goryachev <[email protected]> wrote:

>> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/RangeInfo.java
>>  line 102:
>> 
>>> 100:             int sz = lines.length;
>>> 101:             if (y < lines[0]) {
>>> 102:                 return midPoint(0, lines[0]);
>> 
>> If I take it right, this would be a position in the space/top padding area, 
>> but the caret should go to the first line, therefore, it should be 
>> `midPoint(lines[0], lines[1])`?
>
> I don't think it matters, the `findTextPosLocal()` will find the right 
> position VFlow:1212.

It doesn't matter, indeed, but somehow breaks the symmetry of what is done at 
the bottom side, and if VFlow implementation ever changes, or findHitMidpoint() 
is used elsewhere, that could lead to potential issues.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2280#discussion_r3912566376

Reply via email to