On Tue, 1 Sep 2026 21:57:57 GMT, Jose Pereda <[email protected]> wrote:

>> Andy Goryachev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review comments
>
> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/RangeInfo.java
>  line 101:
> 
>> 99:         if (lines != null) {
>> 100:             int sz = lines.length;
>> 101:             if (y < lines[0]) {
> 
> You'd need to assert that sz > 0

this is taken care of in L56

> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/RangeInfo.java
>  line 103:
> 
>> 101:             if (y < lines[0]) {
>> 102:                 return midPoint(0, lines[0]);
>> 103:             } else if (y >= lines[sz - 1]) {
> 
> make sure sz > 1

L56

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2280#discussion_r3908842811
PR Review Comment: https://git.openjdk.org/jfx/pull/2280#discussion_r3908849381

Reply via email to