On Tue, 6 Jan 2026 00:01:06 GMT, Andy Goryachev <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8373058: Media crash when playing MP3 over JRT protocol on macOS 26 [v2] > > modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp > line 289: > >> 287: mEQBands.clear(); >> 288: >> 289: pthread_mutex_destroy(&mBandLock); > > do we need a conditional here or it's always ok even if the mBandLock was > never used? We always initialize `mBandLock` in constructor, so we need to call `pthread_mutex_destroy`. It should be called if `pthread_mutex_init` was called. Does not matter if we locked/unlocked mutex. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2008#discussion_r2663153595
