On Mon, 15 Dec 2025 23:50:34 GMT, Alexander Matveev <[email protected]>
wrote:
> Fixed two crashes:
> - `shouldWaitForLoadingOfRequestedResource()` was not synchronized with
> `dispose()`.
> - `AddBand()`, `RemoveBand()` and `MoveBand()` was not synchronized with
> `ProcessBufferLists()`.
Suggesting a minor change, otherwise LGTM.
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp
line 270:
> 268: }
> 269:
> 270: AVFAudioEqualizer::~AVFAudioEqualizer() {
Should destroy the mutex in the `~AVFAudioEqualizer()` -->
`pthread_mutex_destroy(&mBandLock);`
-------------
Changes requested by arapte (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/2008#pullrequestreview-3625724607
PR Review Comment: https://git.openjdk.org/jfx/pull/2008#discussion_r2660508538
