On Wed, 17 Sep 2025 23:26:13 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 21 additional >> commits since the last revision: >> >> - snapshot 1 test >> - Merge remote-tracking branch 'origin/master' into 8367567.expected >> - expected >> - single exit common >> - message >> - whitespace >> - launcher test >> - revert add exports >> - decouple logging >> - test.javafx.util >> - ... and 11 more: https://git.openjdk.org/jfx/compare/7d28830b...98f60999 > > modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ErrorLoggingUtility.java > line 36: > >> 34: import com.sun.javafx.logging.PlatformLogger.Level; >> 35: >> 36: public class ErrorLoggingUtility { > > I see you left in the name change to `ErrorLoggingUtility`. I was hoping > you'd revert that along with the other changes to this file, since they are > now unrelated and make the PR much larger to review. Yes, I know it's a > mechanical change, but I find it hard to see what has "really" changed now. > > Suggestion: revert the name change to this utility, since it is no longer > relevant. Further, there are at least some files in javafx.base that are unchanged except for this name change, a reordering of imports, and a copyright year update. See `modules/javafx.base/src/test/java/test/javafx/binding/BindingsArrayTest.java` which has a large number of changes, but I think the whole file would be reverted and untouched (meaning no need for 2025) if you revert the name change. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1897#discussion_r2356997790
