> This PR removes unrelated `stderr` output in the headful test logs by > redirecting it to an in-memory buffer. Exceptions found in the buffer can be > checked against the expected list. > > In the case when any mismatch is detected, whether the type or the number of > exceptions of particular type, the accumulated buffer gets dumped to `stderr` > (without failing the test). > > ## How To > > To redirect stderr and later check the exceptions, surround your code with > > `ErrorLoggingUtility.suppressStderr()` and either > `ErrorLoggingUtility.checkStderr()` or > `ErrorLoggingUtility.checkAndRestoreStderr()`. > > To simply undo redirection, without checking, call > `ErrorLoggingUtility.restoreStderr()`. > > To add the check to all the tests in the file, one can call the above > mentioned methods inside `@BeforeEach` and `@AfterEach`. > > ## Miscellaneous > > For reviewers' convenience, the first commit contains the main change, the > second fixes the misspelt name of the utility class, the rest are trivial. > > ## Questions > > - should we fail the current test with `Assertions.fail()` in case of a > mismatch?
Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: moved utility ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1897/files - new: https://git.openjdk.org/jfx/pull/1897/files/cd1b9463..12e0f6a7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1897&range=03 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1897&range=02-03 Stats: 24 lines in 14 files changed: 3 ins; 10 del; 11 mod Patch: https://git.openjdk.org/jfx/pull/1897.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1897/head:pull/1897 PR: https://git.openjdk.org/jfx/pull/1897
