On Thu, 10 Jul 2025 07:45:26 GMT, Johan Vos <j...@openjdk.org> wrote:
>> After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file >> content is no longer played via GSTPlatform but via OSXPlatform. >> We need to correctly handle data in case the source is a file inside a jar, >> in which case CJavaInputStreamCallbacks is used. >> >> The 2 changes I made are: >> 1. Use ConnectionHolder instead of Locator for CJavaInputStreamCallbacks in >> case a jar resource is used. >> 2. In case of random access datasource, use readBlock instead of >> readNextBlock in AVMediaPlayer > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Remove whitespace Unrelated to this PR: - Changing the rate property for mp3 has no effect (but does change the rate for a .wav). Changing the volume property does work. I wonder if this should be documented. - AudioClip properties specify no default values, we may need to address that. I'll create a separate ticket later. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1839#issuecomment-3058371737