On Thu, 19 Jun 2025 12:48:06 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Adds code to trigger a scene update when a Window is restored >> >> This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and >> https://bugs.openjdk.org/browse/JDK-8146479 > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Also repaint when going to maximized Marked as reviewed by angorya (Reviewer). Looks good on macOS 15.5 M1. Could we test this tested on linux please? I'll add one reviewer temporarily for now just for that. I am going to launch a headful CI run, will report in about an hour. modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassWindowEventHandler.java line 110: > 108: float outScaleY = window.getOutputScaleY(); > 109: stage.stageListener.changedScale(outScaleX, outScaleY); > 110: forceRepaint(); (github diff is confusing, this code is for `WindowEvent.RESCALE` case) I suspect this might also fix an issue that I encountered in one of my applications which uses Canvas-based text editor. After the macOS is woken up after a sleep with an external monitor attached, the text on retina looked blurred. I could not get a reproducer in time, but I think it was because while I put it to sleep, the scene got re-rendered on the external monitor going from scale 2 to scale 1, but when woken up, the scene was correctly re-rendered for retina but the canvas was not resized, requiring it to be scaled. I'll try to test this scenario, but it may take a few days. ------------- PR Review: https://git.openjdk.org/jfx/pull/1733#pullrequestreview-2966964494 PR Comment: https://git.openjdk.org/jfx/pull/1733#issuecomment-3013438979 PR Comment: https://git.openjdk.org/jfx/pull/1733#issuecomment-3013472235 PR Review Comment: https://git.openjdk.org/jfx/pull/1733#discussion_r2172263539
