On Wed, 18 Jun 2025 21:52:22 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>>> I have noticed the tests for maximized stages fail on my system: >> >> That's expected. This PR fixes the case where the window goes from iconified >> to restored. When looking at the code I realized the same fix needs to be >> applied when the window goes from iconified to maximized so I added that to >> the test. > >> > I have noticed the tests for maximized stages fail on my system: >> >> That's expected. This PR fixes the case where the window goes from iconified >> to restored. When looking at the code I realized the same fix needs to be >> applied when the window goes from iconified to maximized so I added that to >> the test. > > Do I need to add additional code for that case? The fix is now in > `WindowEvent.RESTORE`, which I think should be catching both cases, or does > de-iconifying to a maximized stage somehow not send a restore event? The > terms are somewhat confusing; if `RESTORE` indicates go to a > non-maximized/non-minimized/non-iconified "normal" state, then I suppose I > need to add more code in `MAXIMIZE` as well... > > Edit: I see that iconified state is explicitly set to `false` in the > `MAXIMIZE` branch, so it looks like we'd need to do the same there. I'll do > some tests. @hjohn you might want to add [JDK-8146479](https://bugs.openjdk.org/browse/JDK-8146479) to the PR via `/ issue add` command. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1733#issuecomment-3013397520
