On Wed, 11 Jun 2025 17:43:10 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/marlin/OffHeapArray.java line
>> 59:
>>
>>> 57: */
>>> 58: OffHeapArray(final Object parent, final long len) {
>>> 59: this(parent, len, false);
>>
>> I would suggest to remove this constructor.
>
> Since global is the special case, it seemed easier to keep the existing
> constructor and only pass "global=true" in the one place that's needed -- the
> static initializer of `MaskMarlinAlphaConsumer`.
Although... there is only one use now of the default constructor, so it would
be trivial to change it and dispense with the first constructor.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1814#discussion_r2140750760
