On Thu, 5 Jun 2025 15:32:36 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> I'm okay with bumping the required version. It seems like 3.8 was released >> 12 years ago, and we would be requiring a version that was released 9 years >> ago. Sounds fair. > > Our production build system is Oracle Linux 8, which has GTK 3.22. > > The oldest system I now have access to is Ubuntu 16.04 (yeah, I know...it's > probably time to retire it), which has GTK 3.18. I build JavaFX using GCC > 14.2 (via a devkit) and compile against a GTK 3.22 header files and library. > I'm able to run this PR and use the EXTENDED stage style with a HeaderBar, > but when I try to use the context menu it crashes: > > > java: symbol lookup error: build/sdk/lib/libglassgtk3.so: undefined symbol: > gdk_display_get_default_seat > > > We should make a deliberate decision as to whether or not to bump the > minimum. I think bumping the minimum to 3.20 might be reasonable thing to, > although I'd want to do it separately from this PR and provide a release note > for that. Worth noting is that we only recently upgraded our production build env from Oracle Linux 7, which is now out of support. Bumping the minimum GTK version to 3.20 will preclude running on OL 7 / RHEL 7 at all (RHEL 7 has GTK 3.8, which is why that minimum was chosen). I think this is OK, but is another reason I want to see a separate JBS issue to bump the minimum. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2129145160
