On Thu, 5 Jun 2025 00:12:43 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> enable preview feature system properties for tests > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1418: > >> 1416: >> 1417: gdk_window_show_window_menu(gdk_window, event); >> 1418: gdk_event_free(event); > > The `seat` concept was introduced in gtk 3.20 and > `gdk_window_show_window_menu` was in 3.14, and we require 3.8. > I would agree that it's time to bump it up. Is there anything we need to change here? > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.h line 132: > >> 130: virtual void set_alpha(double) = 0; >> 131: virtual void set_enabled(bool) = 0; >> 132: virtual void set_system_minimum_size(int, int) = 0; > > Maybe `set_headerbar_mininum_size()` ? Hmm... but it's not the minimum size of the header bar, it's the minimum size of the window. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2127737900 PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2127739124