On Sat, 3 May 2025 08:56:07 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Implementation of [CSS media >> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 30 commits: > > - Merge branch 'master' into feature/media-queries > - cssref doc > - Merge branch 'master' into feature/media-queries > - reorder fields > - remove ReadOnlyBooleanWrapper > - Scene preferences only actively observe platform preferences when the > scene is showing > - formatting > - typo > - use equality instead of identity > - rename TokenStream methods > - ... and 20 more: https://git.openjdk.org/jfx/compare/498b7e4c...626a904d modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaQueryParser.java line 216: > 214: > 215: if (tokens.consumeIf(RPAREN) == null) { > 216: errorHandler.accept(tokens.consume(), "Expected RPAREN"); RPAREN -> right parenthesis ')'? modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaQueryParser.java line 223: > 221: } > 222: > 223: errorHandler.accept(tokens.consume(), "Expected LPAREN"); LPAREN -> left parenthesis ')'? modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaQueryParser.java line 241: > 239: private MediaQuery parseMediaFeature(TokenStream tokens) { > 240: if (tokens.consumeIf(LPAREN) == null) { > 241: errorHandler.accept(tokens.consume(), "Expected LPAREN"); LPAREN? also LL247, 259 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2074166798 PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2074167103 PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2074167504
