On Tue, 4 Feb 2025 13:17:09 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add "maximized" pseudo-class for custom maximize button > > It looks like this is shaping up nicely. I'll put this on my review queue. > > One thing I wanted to raise is that there are a few new concepts here as well > as a reasonably large API surface. This feature seems like a good candidate > to release as a Preview Feature (*) to get more feedback on the API before > finalizing it. That would mean reviving your [Preview Feature JEP / Draft > PR](https://github.com/openjdk/jfx/pull/1359), which you had also mentioned > as something to consider in your initial Description of this PR. Do you have > any thoughts on this? > > (*) - It can't be an incubator module (at least not without doing something > unnatural like creating a subclass of Stage, and that might not even work), > since the new API elements and implementation are necessarily in the > `javafx.graphics module`. > @kevinrushforth After several rounds of revision, I think the API is in a > good shape by now. Do you have a chance to take a look at it, so that I can > continue with the CSR? Yes, I'll put it on my review queue for this week. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2836455951
