On Thu, 3 Apr 2025 08:48:47 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Issue: >> The test execution fails when a relative path is specified a relative path >> for `TEST_SDK_PATH`. >> For example: >> 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test >> 2. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**~**/jfx1/build test >> >> Solution: >> Convert the relative path to an absolute path. >> >> More about fix: >> The property TEST_SDK_PATH belongs to the root project rt in build.gradle. >> If we modify this property in build.gradle, it does not reflect in the child >> projects. The child projects for example graphics, controls would still have >> the value of TEST_SDK_PATH before modification. >> To solve this, I Introduced a new variable in build.gradle `TEST_SDK_DIR`. >> It would hold the modified value of `TEST_SDK_PATH` and gets correctly >> reflected across all sub-projects. >> >> Verified that both relative paths and absolute path work fine after this >> change. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > review fix LGTM ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1751#pullrequestreview-2739719022
