On Tue, 18 Feb 2025 11:13:14 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:

>> 8350917: Allow parent nodes to provide CSS styleable properties for child 
>> nodes
>
> @mstr2 / Dirk Lemmermann : This is a proof of concept PR for parent provided 
> properties.  I've adapted HBox / VBox only in this PR, and I probably need to 
> update the CSS documentation still.  I've opted to leave out the static HBox 
> / VBox method to get these as a property (ie. `hgrowProperty`) although a 
> property is used internally and so it could be exposed fairly easily later.  
> My plan is:
> 
> - Get some early feedback on the implementation, naming and the new API 
> method in Styleable
> - Decide the scope of this PR; I'd be in favor to get the core code in, then 
> add more support later to ease reviews
>    - Include new static property methods as well?
>    - Include GridPane as well?
>    - Any other controls?
> - Add some specific unit tests for this new feature
> - Update CSS docs
> - Ready for review
> - Integrate

> Only the author (@hjohn) is allowed to issue the reviewer command.

That's weird isn't it?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1714#issuecomment-2695603370

Reply via email to