On Fri, 28 Feb 2025 23:08:23 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> I think the main concern with the reformatting/tangentially related changes > coming from the maintainers is the general pain associated with conflicts > created when merging and backporting. It's not just this, it's also about avoiding changes in parts of the code you aren't touching. When you do this, reviewers have to look at a hole bunch of changes that aren't related to the fix. > In this case, I think we might be ok, specifically in the tests. I would > rather see the cleaner and more maintainable code, even at the small > additional expense. Up to you. If a fix touches only one method of a file with many methods, I very much do not want to see the entire file reformatted as part of that fix. So I recommend to either reformat the one method or leave it alone. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1723#discussion_r1978183387
